fix(@schematics/update): remove update all suggestion message #14760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The language within the message specifies that update all will _try_ to update all the packages. In practice and especially for larger projects, this operation will mostly likely not succeed. This can lead to the users attempting to use the all option with the force option which has a decent probability to break the project via incorrect peer dependency installation or other incompability version increases (packages that don't follow semver, for instance). Reference: angular#14561 (comment)
clydin
added
the
needs: discussion
alan-agius4
approved these changes
Jun 13, 2019
alan-agius4
removed
the
needs: discussion
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language within the message specifies that update all will try to update all the packages. In practice and especially for larger projects, this operation will mostly likely not succeed. This can lead to the users attempting to use the all option with the force option which has a decent probability to break the project via incorrect peer dependency installation or other incompability version increases (packages that don't follow semver, for instance).
Reference: #14561 (comment)